-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Get and update primer primitives automatically #253
Conversation
@tmillr, I'm getting ready to launch a major version of this colorscheme, which will be released soon. Once it's out, I'll review your pull requests (PRs) and merge them into the main branch. This approach will give us a solid base version that incorporates the newly added feature and allows us to track any additional modifications you mentioned. It will facilitate easier identification and monitoring of changes, enabling us to release minor versions accordingly. Thank you for your understanding. |
Awesome sounds good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump version
to 1.0.0
I ran/tested the embedded shell script locally and then was able to successfully |
Introduce a GitHub workflow which runs on a schedule 3 times per week to pull in all of the exact color definitions for each theme directly from the
@primer/primitives
npm package. This pr adds apackage.json
file for clarity and for dependency tracking/declarations, as well as a new workflow file which is quite simple and uses npm. The workflow goes something like this:@primer/primitives
npm package in CIlua/github-theme/palettes/primitives
make fmt
to format all Lua filespeter-evans/create-pull-request@v5
gh action, which will create a pr if there were any updates/changesThese color definitions will live under the new directory
lua/github-theme/palettes/primitives
and may be required from Lua at runtime (e.g. in order to build up specs).The workflow may also be run manually via
workflow_dispatch
.