fix(config): options.darken.floats is not used
#345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmillr
force-pushed
the
fix-options-darken-floats
branch
2 times, most recently
from
6970f32 to
57f8d90
Compare
Problem: `options.darken.floats` isn't used anywhere and `NormalFloat`
is unconditionally set to `spec.bg0` (darker background).
Solution: Only set `bg` of `NormalFloat` to `bg0` if
`options.darken.floats` is `true`, otherwise, set it to `bg1`
(default background).
Problem: Floating windows are darkened unconditionally and
`options.darken.floats` appears to be documented as being
`true` by default (see `options.darken` section of Usage.md),
however, the actual default in `config.lua` is `false`. In
README.md, the default value is properly documented as being
`false`.
Solution: Change the default value of `options.darken.floats` to `true`.
Update the documented default to `true`. This is not a
breaking change because this is currently the default
behavior.
tmillr
force-pushed
the
fix-options-darken-floats
branch
from
57f8d90 to
24fc179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
options.darken.floatsisn't used anywhere andNormalFloatis unconditionally set tospec.bg0(darker background).Solution: Only set
bgofNormalFloattobg0ifoptions.darken.floatsistrue, otherwise, set it tobg1(default background).Problem: Floating windows are darkened unconditionally and
options.darken.floatsappears to be documented as beingtrueby default (seeoptions.darkensection of Usage.md), however, the actual default inconfig.luaisfalse. In README.md, the default value is properly documented as beingfalse.Solution: Change the default value of
options.darken.floatstotrue. Update the documented default totrue. This is not a breaking change because this is currently the default behavior.