feat(overrides): improve highlight-group overrides #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmillr
force-pushed
the
fix-group-overrides
branch
from
af30c71 to
c520dab
Compare
tmillr
changed the title
tmillr
force-pushed
the
fix-group-overrides
branch
2 times, most recently
from
98d6481 to
2364451
Compare
tmillr
changed the title
- Assigning `false` or an empty table to a highlight group clears it - Assigning `false` to groups/specs/palettes clears previous settings from the config store (like `reset()` but finer-grained) - (internal) Use `false` instead of `link = ''` to mark groups which should be cleared when set - Improve `github-theme.group` - Improve/cleanup code and other minor improvements (code-sharing, simplification, etc.)
tmillr
force-pushed
the
fix-group-overrides
branch
from
2364451 to
0e62bf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigning
falseor an empty table to a highlight group clears itAssigning
falseto groups/specs/palettes clears previous settings from the config store (likereset()but finer-grained)(internal) Use
falseinstead oflink = ''to mark groups which should be cleared when setImprove
github-theme.groupImprove/cleanup code and other minor improvements (code-sharing, simplification, etc.)