Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Simcoe Example Project #28

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[Feature] Simcoe Example Project #28

wants to merge 14 commits into from

Conversation

jgsamudio
Copy link

  • Added a sample project to the Simcoe Workspace.

@jgsamudio jgsamudio changed the base branch from master to feature/swift3 February 23, 2017 22:59
@yoyoyoseob yoyoyoseob added this to the 1.0.0 milestone Feb 27, 2017
@yoyoyoseob yoyoyoseob modified the milestones: 1.0.0, 1.1.0 Mar 7, 2017
@jgsamudio jgsamudio changed the base branch from feature/swift3 to master March 20, 2017 20:07
@atecle
Copy link

atecle commented Mar 20, 2017 •
edited
Loading

Noticed a couple general things, but not sure if I need context on this PR so lemme know if so

  1. Are SimcoeExample and SimcoeExample3 supposed to be included in this PR? SimcoeExample2 is the runnable one. If not, should remove the unused projects and rename the name of the example project for the repo to not include a number
  2. Could definitely use a better directory structure for the project. AppDelegate/info.plist/etc in Supporting Files. Maybe group the other files by feature/related functionality or Models/Views/View Controllers Oops, realized SimcoeExample has a different directory structure. There's no Podfile in the main project folder so couldn't run it

@yoyoyoseob yoyoyoseob removed this from the 1.1.0 milestone Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htinlinn htinlinn Awaiting requested review from htinlinn

@MichaelCampbell MichaelCampbell Awaiting requested review from MichaelCampbell

@atecle atecle Awaiting requested review from atecle

@yoyoyoseob yoyoyoseob Awaiting requested review from yoyoyoseob

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgsamudio @atecle @yoyoyoseob