Merge pull request #439 from 0x46616c6b/fix-node-stats-metrics

fix _/node/stats related metrics
prometheus-community · Jun 16, 2021 · a4c1f63 · a4c1f63
2 parents 404109a + df0f1d0
commit a4c1f63
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/collector/nodes_response.go b/collector/nodes_response.go
@@ -37,7 +37,7 @@ type NodeStatsNodeResponse struct {
 	ThreadPool       map[string]NodeStatsThreadPoolPoolResponse `json:"thread_pool"`
 	JVM              NodeStatsJVMResponse                       `json:"jvm"`
 	Breakers         map[string]NodeStatsBreakersResponse       `json:"breakers"`
-	HTTP             map[string]int                             `json:"http"`
+	HTTP             map[string]interface{}                     `json:"http"`
 	Transport        NodeStatsTransportResponse                 `json:"transport"`
 	Process          NodeStatsProcessResponse                   `json:"process"`
 }

diff --git a/collector/nodes_test.go b/collector/nodes_test.go
@@ -51,11 +51,6 @@ func TestNodesStats(t *testing.T) {
 		for hn, handler := range handlers {
 			t.Run(fmt.Sprintf("%s/%s", hn, ver), func(t *testing.T) {
 
-				// TODO(@sysadmind): Remove this skip once we have a fix for v7.13.1 of elasticsearch
-				if ver == "7.13.1" {
-					t.Skip("7.13.1 has a breaking change and the fix has not yet been implemented.")
-				}
-
 				ts := httptest.NewServer(handler)
 				defer ts.Close()