Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose load averages #113

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Expose load averages #113

merged 1 commit into from
Dec 13, 2017

Conversation

pchristos
Copy link
Contributor

Tested against versions 5.1.2 - 5.6.4

@dominikschulz
Copy link
Contributor

I'm not sure if this should be in this exporter. It looks more like something you'd want to do with the node exporter.

@pchristos
Copy link
Contributor Author

What if someone has his Elasticsearch hosted aaS with no access to the nodes? Node exporter would have to be deployed on the nodes themselves, right? Plus, metrics like CPU, which are not Elasticsearch-specific, are already being exported.

@zwopir
Copy link
Member

zwopir commented Dec 11, 2017

@dominikschulz is right about that the data itself is redundant with the metrics provided by the node exporter. But the data is exported by the nodes endpoint anyways, so it doesn't make a big difference to create a metric from it or not. On the plus side:

  • you get at least some OS metrics on hosted ES
  • the OS metrics exported via the elasticsearch_exporter have the same labels as the ES metrics

so I'd vote for accepting this PR.

@pchristos could you add some tests in nodes_test.go that you can access the necessary fields in all supported versions?! we have fixture JSONs inline in the test file, so it's just a matter of checking that the struct fields are not nil or the type initialization value

@dominikschulz
Copy link
Contributor

SGTM

@zwopir zwopir merged commit 85ef0bf into prometheus-community:master Dec 13, 2017
@zwopir
Copy link
Member

zwopir commented Dec 13, 2017

just merged. Thanks for your contribution, @pchristos !

@pchristos pchristos deleted the load branch March 11, 2018 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants