Fix snapshot_stats metrics which happens on HA hdfs type snapshot rep… #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ository fix issue 415 err logs: "failed to fetch and decode snapshot stats" err:"json: cannot unmarshal object into Go struct field .settings of type string" " repository-hdfs is an elasticsearch plugin: https://www.elastic.co/guide/en/elasticsearch/plugins/current/repository-hdfs-config.html#repository-hdfs-config Signed-off-by: bruc vv <brucvv@gmail.com>
bydeath
force-pushed
the
fix-snapshot_stats_unmarshal_err
branch
from
a5ba19c to
4f20bba
Compare
caarlos0
reviewed
Jun 17, 2021
collector/snapshots_reponse.go
Outdated
| Type string `json:"type"` | ||
| Settings map[string]string `json:"settings"` | ||
| Type string `json:"type"` | ||
| Settings map[string]interface{} `json:"settings"` |
There was a problem hiding this comment.
if we don't use the value of settings anywhere, we could just remove the field 🤔
There was a problem hiding this comment.
It seems the value of settings is not used now. I tried it worked without Settings field, and it's another way to fix the bug.
remove unused field `Settings` of the struct `SnapshotRepositoriesResponse`. Signed-off-by: bruc vv <brucvv@gmail.com>
bydeath
force-pushed
the
fix-snapshot_stats_unmarshal_err
branch
from
b99d073 to
3bad103
Compare
sysadmind
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ository
fix issue #415
err logs: "failed to fetch and decode snapshot stats" err:"json: cannot unmarshal object into Go struct field .settings of type string" "
repository-hdfs is an elasticsearch plugin: https://www.elastic.co/guide/en/elasticsearch/plugins/current/repository-hdfs-config.html#repository-hdfs-config