-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-existing CPU metrics #498
Merged
SuperQ
merged 2 commits into
prometheus-community:master
from
multani:simplify-cpu-metrics
Jan 19, 2022
Merged
Remove non-existing CPU metrics #498
SuperQ
merged 2 commits into
prometheus-community:master
from
multani:simplify-cpu-metrics
Jan 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't find any Elasticsearch versions where these CPU metrics were exposed, so they are always set to 0. Signed-off-by: Jonathan Ballet <jonathan.ballet@camunda.com>
Signed-off-by: Jonathan Ballet <jonathan.ballet@camunda.com>
multani
force-pushed
the
simplify-cpu-metrics
branch
from
November 10, 2021 14:46
56d3050
to
da95fac
Compare
I can't confirm all versions, but I can say that these are always 0 for my 7.x setup |
SuperQ
approved these changes
Jan 19, 2022
SuperQ
added a commit
that referenced
this pull request
Jan 19, 2022
With PR #498, we only have one process CPU metric. * Drop the label. * Update the name to match Prometheus naming. Signed-off-by: SuperQ <superq@gmail.com>
sysadmind
pushed a commit
that referenced
this pull request
Jan 19, 2022
With PR #498, we only have one process CPU metric. * Drop the label. * Update the name to match Prometheus naming. Signed-off-by: SuperQ <superq@gmail.com>
iishabakaev
pushed a commit
to iishabakaev/elasticsearch_exporter
that referenced
this pull request
Jun 8, 2022
* Remove non-existing CPU metrics I couldn't find any Elasticsearch versions where these CPU metrics were exposed, so they are always set to 0. Signed-off-by: Jonathan Ballet <jonathan.ballet@camunda.com> * remove more Signed-off-by: Jonathan Ballet <jonathan.ballet@camunda.com> Signed-off-by: iishabakaev <iishabakaev@gmail.com>
iishabakaev
pushed a commit
to iishabakaev/elasticsearch_exporter
that referenced
this pull request
Jun 8, 2022
With PR prometheus-community#498, we only have one process CPU metric. * Drop the label. * Update the name to match Prometheus naming. Signed-off-by: SuperQ <superq@gmail.com> Signed-off-by: iishabakaev <iishabakaev@gmail.com>
jnadler
pushed a commit
to jnadler/elasticsearch_exporter
that referenced
this pull request
Oct 27, 2022
* Remove non-existing CPU metrics I couldn't find any Elasticsearch versions where these CPU metrics were exposed, so they are always set to 0. Signed-off-by: Jonathan Ballet <jonathan.ballet@camunda.com> * remove more Signed-off-by: Jonathan Ballet <jonathan.ballet@camunda.com>
jnadler
pushed a commit
to jnadler/elasticsearch_exporter
that referenced
this pull request
Oct 27, 2022
With PR prometheus-community#498, we only have one process CPU metric. * Drop the label. * Update the name to match Prometheus naming. Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find any Elasticsearch versions where these CPU metrics
were exposed, so they are always set to 0.