Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-existing CPU metrics #498

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

multani
Copy link
Contributor

@multani multani commented Nov 10, 2021

I couldn't find any Elasticsearch versions where these CPU metrics
were exposed, so they are always set to 0.

I couldn't find any Elasticsearch versions where these CPU metrics
were exposed, so they are always set to 0.

Signed-off-by: Jonathan Ballet <jonathan.ballet@camunda.com>
Signed-off-by: Jonathan Ballet <jonathan.ballet@camunda.com>
@multani multani force-pushed the simplify-cpu-metrics branch from 56d3050 to da95fac Compare November 10, 2021 14:46
@SuperQ
Copy link
Contributor

SuperQ commented Jan 19, 2022

I can't confirm all versions, but I can say that these are always 0 for my 7.x setup

@SuperQ SuperQ merged commit b4aac6f into prometheus-community:master Jan 19, 2022
SuperQ added a commit that referenced this pull request Jan 19, 2022
With PR #498, we only have one process CPU metric.
* Drop the label.
* Update the name to match Prometheus naming.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Jan 19, 2022
sysadmind pushed a commit that referenced this pull request Jan 19, 2022
With PR #498, we only have one process CPU metric.
* Drop the label.
* Update the name to match Prometheus naming.

Signed-off-by: SuperQ <superq@gmail.com>
@multani multani deleted the simplify-cpu-metrics branch April 21, 2022 07:55
iishabakaev pushed a commit to iishabakaev/elasticsearch_exporter that referenced this pull request Jun 8, 2022
* Remove non-existing CPU metrics

I couldn't find any Elasticsearch versions where these CPU metrics
were exposed, so they are always set to 0.

Signed-off-by: Jonathan Ballet <jonathan.ballet@camunda.com>

* remove more

Signed-off-by: Jonathan Ballet <jonathan.ballet@camunda.com>
Signed-off-by: iishabakaev <iishabakaev@gmail.com>
iishabakaev pushed a commit to iishabakaev/elasticsearch_exporter that referenced this pull request Jun 8, 2022
With PR prometheus-community#498, we only have one process CPU metric.
* Drop the label.
* Update the name to match Prometheus naming.

Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: iishabakaev <iishabakaev@gmail.com>
jnadler pushed a commit to jnadler/elasticsearch_exporter that referenced this pull request Oct 27, 2022
* Remove non-existing CPU metrics

I couldn't find any Elasticsearch versions where these CPU metrics
were exposed, so they are always set to 0.

Signed-off-by: Jonathan Ballet <jonathan.ballet@camunda.com>

* remove more

Signed-off-by: Jonathan Ballet <jonathan.ballet@camunda.com>
jnadler pushed a commit to jnadler/elasticsearch_exporter that referenced this pull request Oct 27, 2022
With PR prometheus-community#498, we only have one process CPU metric.
* Drop the label.
* Update the name to match Prometheus naming.

Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants