Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't specify namespaceSelector when running in same namespace #1382

Closed
james-callahan opened this issue Sep 29, 2021 · 1 comment · Fixed by #1383
Closed

Don't specify namespaceSelector when running in same namespace #1382

james-callahan opened this issue Sep 29, 2021 · 1 comment · Fixed by #1383

Comments

@james-callahan
Copy link

#1343 broke namespace independence of ServiceMonitor resources.
namespaceSelector shouldn't be set unless it's pointing at a different namespace, or explicitly overridden
@james-callahan james-callahan mentioned this issue Sep 29, 2021
Merged
3 tasks
@sathieu
Copy link
Contributor

sathieu commented Sep 29, 2021

Thanks @james-callahan. Will propose a PR shortly.

sathieu added a commit to sathieu/helm-charts-prometheus-community that referenced this issue Sep 29, 2021
@sathieu
[kube-prometheus-stack] Move ServiceMonitor back to main namespace, a…
4fdc00d 
…nd use namespaceSelector only when needed

Fixes: prometheus-community#1382
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
@sathieu sathieu mentioned this issue Sep 29, 2021
Merged
3 tasks
sathieu added a commit to sathieu/helm-charts-prometheus-community that referenced this issue Oct 1, 2021
@sathieu
[kube-prometheus-stack] Do not specify ServiceMonitor namespace selec…
6c21f74 
…tors

... when in the same namespace.

Fixes: prometheus-community#1382
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sathieu @james-callahan