[kube-prometheus-stack] Allow either type of imagePullSecrets #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Harrison <simon.harrison@mediakind.com>
SimonHarrisonSH
requested review from
andrewgkew,
bismarck,
desaintmartin,
gianrubio,
gkarthiks,
scottrigby and
Xtigyro
as code owners
SimonHarrisonSH
changed the title
|
Tagging code owners: @andrewgkew @bismarck @desaintmartin @gianrubio @gkarthiks @scottrigby @Xtigyro |
monotek
requested changes
May 21, 2022
Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: SimonHarrisonSH <simon.harrison.sh@gmail.com>
Signed-off-by: SimonHarrisonSH <simon.harrison.sh@gmail.com>
|
Hi, @monotek, |
|
To whoever reviews this next. I bumped the chart version because the version on Main got bumped before this was reviewed. I've been keeping an eye on it all week, and it's not changed again, but I can see there are a number of other PR's waiting, so it's possible. If it get's bumped again before this gets reviewed, feel free to bump this as well :) |
monotek
approved these changes
May 27, 2022
amuraru
pushed a commit
to amuraru/helm-charts-1
that referenced
this pull request
May 29, 2022
…heus-community#2056) * Allow either type of imagePullSecrets Signed-off-by: Simon Harrison <simon.harrison@mediakind.com> * Bump version Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: SimonHarrisonSH <simon.harrison.sh@gmail.com> Co-authored-by: Simon Harrison <simon.harrison@mediakind.com>
artificial-aidan
pushed a commit
to artificialinc/prometheus-community-helm-charts
that referenced
this pull request
Jun 10, 2022
…heus-community#2056) * Allow either type of imagePullSecrets Signed-off-by: Simon Harrison <simon.harrison@mediakind.com> * Bump version Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: SimonHarrisonSH <simon.harrison.sh@gmail.com> Co-authored-by: Simon Harrison <simon.harrison@mediakind.com> Signed-off-by: Aidan Jensen <aidan@artificial.com>
stamzid
pushed a commit
to Unstructured-IO/prometheus-community-helm-charts
that referenced
this pull request
Mar 3, 2023
…heus-community#2056) * Allow either type of imagePullSecrets Signed-off-by: Simon Harrison <simon.harrison@mediakind.com> * Bump version Co-authored-by: André Bauer <monotek@users.noreply.github.com> Signed-off-by: SimonHarrisonSH <simon.harrison.sh@gmail.com> Co-authored-by: Simon Harrison <simon.harrison@mediakind.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simon Harrison simon.harrison@mediakind.com
What this PR does / why we need it:
These hierarchical charts can be deployed as part of another hierarchical chart. There is only one
Globalscope, which causes problems because kps uses one format forimagePullSecretsvalues, and most other public charts use another. This PR allows either type to be specified globally, and the helper will deal with it for the kps scoped secretWhich issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
ct lint-and-install has passed
Checklist
[prometheus-couchdb-exporter])