[kube-prometheus-stack] Change AlertManager and Prometheus CR naming. #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksa-real
requested review from
andrewgkew,
bismarck,
desaintmartin,
gianrubio,
gkarthiks,
scottrigby and
Xtigyro
as code owners
cc @andrewgkew @bismarck @desaintmartin @monotek Please speak out if you guys have specific reasons, especially the non-preferred design that cannot express in the code. Thank you. |
zanhsieh
previously approved these changes
Jun 25, 2022
|
@Xtigyro |
|
@Xtigyro friendly ping |
monotek
requested changes
Jul 28, 2022
This is to avoid weird dependent object names. AlertManager instance is named `releasename-alertmanager`, which results in most dependent objects be named `alertmanager-releasename-alertname`. Same for Prometheus CR. Generated PersistentVolume is particularly bad: `prometheus-releasename-prometheus-db-prometheus-releasename-prometheus-0`. If .Release.Name is `main` and we are not using .Values.nameoverride then we get insane `prometheus-main-kube-prometheus-stack-prometheus-db-prometheus-main-kube-prometheus-stack-prometheus-db-0`. Signed-off-by: Sergei Kuzmin <sergeikuzmin@gmail.com>
monotek
requested changes
Jul 28, 2022
Signed-off-by: Sergei Kuzmin <sergeikuzmin@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com>
Signed-off-by: Sergei Kuzmin <sergeikuzmin@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com>
monotek
requested changes
Jul 29, 2022
Co-authored-by: André Bauer <monotek@users.noreply.github.com>
monotek
approved these changes
Jul 31, 2022
stamzid
pushed a commit
to Unstructured-IO/prometheus-community-helm-charts
that referenced
this pull request
Mar 3, 2023
…prometheus-community#2188) * [kube-prometheus-stack] Change AlertManager and Prometheus CR naming. This is to avoid weird dependent object names. AlertManager instance is named `releasename-alertmanager`, which results in most dependent objects be named `alertmanager-releasename-alertname`. Same for Prometheus CR. Generated PersistentVolume is particularly bad: `prometheus-releasename-prometheus-db-prometheus-releasename-prometheus-0`. If .Release.Name is `main` and we are not using .Values.nameoverride then we get insane `prometheus-main-kube-prometheus-stack-prometheus-db-prometheus-main-kube-prometheus-stack-prometheus-db-0`. Signed-off-by: Sergei Kuzmin <sergeikuzmin@gmail.com> * Update charts/kube-prometheus-stack/values.yaml Signed-off-by: Sergei Kuzmin <sergeikuzmin@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com> * Update charts/kube-prometheus-stack/values.yaml Signed-off-by: Sergei Kuzmin <sergeikuzmin@gmail.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com> * Update charts/kube-prometheus-stack/Chart.yaml Co-authored-by: André Bauer <monotek@users.noreply.github.com> Co-authored-by: André Bauer <monotek@users.noreply.github.com> Co-authored-by: MH <zanhsieh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid weird dependent object names. AlertManager instance is
named
releasename-alertmanager, which results in most dependentobjects be named
alertmanager-releasename-alertname. Same forPrometheus CR. Generated PersistentVolume is particularly bad:
prometheus-releasename-prometheus-db-prometheus-releasename-prometheus-0.If .Release.Name is
mainand we are not using .Values.nameoverridethen we get insane
prometheus-main-kube-prometheus-stack-prometheus-db-prometheus-main-kube-prometheus-stack-prometheus-db-0.Signed-off-by: Sergei Kuzmin sergeikuzmin@gmail.com
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter])