kube-prometheus-stack: fix network policy api missing template #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirbilu
requested review from
andrewgkew,
desaintmartin,
gianrubio,
gkarthiks,
scottrigby and
Xtigyro
as code owners
monotek
requested changes
Oct 19, 2022
Signed-off-by: Amir Bilu <amirbilu@gmail.com>
amirbilu
force-pushed
the
fix-network-policy-api
branch
from
fd9b810 to
4ade703
Compare
amirbilu
changed the title
Sure! sorry for missing this |
monotek
approved these changes
Oct 19, 2022
stamzid
pushed a commit
to Unstructured-IO/prometheus-community-helm-charts
that referenced
this pull request
Mar 3, 2023
Signed-off-by: Amir Bilu <amirbilu@gmail.com> Signed-off-by: Amir Bilu <amirbilu@gmail.com>
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
May 16, 2023
Signed-off-by: Amir Bilu <amirbilu@gmail.com> Signed-off-by: Amir Bilu <amirbilu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
https://github.com/prometheus-community/helm-charts/pull/2580/files#diff-85a3dc19698b0354069cf3f9c89eb4a790506d3dd6d9e1e1c38b9c4aa9795d1dR2 which adds
NetworkPolicyreferences a missing templateWhich issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])