[prometheus-kube-stack] Fixes deployment of Thanos Ruler - Addresses Default Thanos Ruler name too long #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmcafee
requested review from
andrewgkew,
gianrubio,
gkarthiks,
scottrigby and
Xtigyro
as code owners
…os-rule suffix to ensure that the thanos ruler name is always under the required 63 characters for resource names. Added support for overriding the value directly from the values file for the thanos ruler name. Signed-off-by: Ryan McAfee <ryan.mcafee@jupiterone.com>
Signed-off-by: Ryan McAfee <ryan.mcafee@jupiterone.com>
monotek
approved these changes
Feb 14, 2023
stamzid
pushed a commit
to Unstructured-IO/prometheus-community-helm-charts
that referenced
this pull request
Mar 3, 2023
…Default Thanos Ruler name too long (prometheus-community#3021) * Updated thanos ruler name to use the shortened helm chart name + thanos-rule suffix to ensure that the thanos ruler name is always under the required 63 characters for resource names. Added support for overriding the value directly from the values file for the thanos ruler name. Signed-off-by: Ryan McAfee <ryan.mcafee@jupiterone.com> * Bump kube-prometheus-stack helm chart version to 45.0.1 Signed-off-by: Ryan McAfee <ryan.mcafee@jupiterone.com> --------- Signed-off-by: Ryan McAfee <ryan.mcafee@jupiterone.com>
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
May 16, 2023
…Default Thanos Ruler name too long (prometheus-community#3021) * Updated thanos ruler name to use the shortened helm chart name + thanos-rule suffix to ensure that the thanos ruler name is always under the required 63 characters for resource names. Added support for overriding the value directly from the values file for the thanos ruler name. Signed-off-by: Ryan McAfee <ryan.mcafee@jupiterone.com> * Bump kube-prometheus-stack helm chart version to 45.0.1 Signed-off-by: Ryan McAfee <ryan.mcafee@jupiterone.com> --------- Signed-off-by: Ryan McAfee <ryan.mcafee@jupiterone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Allows for deployment of Thanos Ruler
Fixes error where the thanos-ruler name was too long (longer then 63 characters, since thanos-ruler resources were using the chart fullname and not the shortened name)
Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])