[prometheus-json-exporter] Fix ConfigMap name inconsistency #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiu
reviewed
Oct 2, 2023
gtirloni
force-pushed
the
fix/json-exporter-fullname
branch
from
2a9433b to
eefb3ad
Compare
Signed-off-by: Giovanni Tirloni <gtirloni@tight-ship.net>
gtirloni
force-pushed
the
fix/json-exporter-fullname
branch
from
eefb3ad to
cfcffb9
Compare
|
@xiu in terms of bumping the Chart version, do you think this is should be 0.8.0 or just 0.7.x ? |
0.8.0 would be good 👍 Thanks for the contribution! |
|
Oh ok, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
ConfigMap's name doesn't follow the same naming pattern as other resources. This PR uses the same fullname template for configmaps.
Checklist
[prometheus-couchdb-exporter])