Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix python version for lint-test #5085

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

dotdc
Copy link
Member

@dotdc dotdc commented Dec 22, 2024

What this PR does / why we need it

Trying python 3.11 to fix error in lint-test workflow:

  Version 3.7 was not found in the local cache
  Error: The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: David Calvert <david@0xdc.me>
@dotdc dotdc requested review from jkroepke, GMartinez-Sisti and a team as code owners December 22, 2024 08:29
@dotdc dotdc mentioned this pull request Dec 22, 2024
1 task
@jkroepke
Copy link
Member

Could you remove lines 65-67?

Seems like the step Apply Gateway API CRDs exists twice and one of them does have a wrong condition

monotek
monotek previously approved these changes Dec 22, 2024
Signed-off-by: David Calvert <david@0xdc.me>
@dotdc
Copy link
Member Author

dotdc commented Dec 22, 2024

Could you remove lines 65-67?

Seems like the step Apply Gateway API CRDs exists twice and one of them does have a wrong condition

Done 👍

@monotek monotek merged commit 17ca2d8 into prometheus-community:main Dec 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Python 3.7 not available in ubuntu-latest
3 participants