Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Recommanded Kubernetes labels #692

Merged
merged 6 commits into from
Apr 21, 2021

Conversation

nlamirault
Copy link
Contributor

@nlamirault nlamirault commented Feb 20, 2021

See: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

Signed-off-by: Nicolas Lamirault nicolas.lamirault@gmail.com

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@stale
Copy link

stale bot commented Apr 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

Copy link
Member

@gkarthiks gkarthiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Copy link
Member

@gkarthiks gkarthiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gkarthiks gkarthiks merged commit 6de72b0 into prometheus-community:main Apr 21, 2021
gkarthiks added a commit that referenced this pull request Apr 21, 2021
langecode pushed a commit to neticdk/helm-charts that referenced this pull request Aug 12, 2021
…munity#692)

* Add: Recommanded Kubernetes labels

See: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

* Update: chart version

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

* Update: bump Chart version

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Thor Anker Kvisgård Lange <tal@netic.dk>
stamzid pushed a commit to Unstructured-IO/prometheus-community-helm-charts that referenced this pull request Mar 3, 2023
…munity#692)

* Add: Recommanded Kubernetes labels

See: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

* Update: chart version

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>

* Update: bump Chart version

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants