-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kube-prometheus-stack] Recommanded Kubernetes labels #692
[kube-prometheus-stack] Recommanded Kubernetes labels #692
Conversation
See: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This reverts commit 6de72b0.
…munity#692) * Add: Recommanded Kubernetes labels See: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Update: chart version Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Update: bump Chart version Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> Signed-off-by: Thor Anker Kvisgård Lange <tal@netic.dk>
…munity#692) * Add: Recommanded Kubernetes labels See: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Update: chart version Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * Update: bump Chart version Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
See: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
Signed-off-by: Nicolas Lamirault nicolas.lamirault@gmail.com
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter]
)