chore!: adopt slog, drop go-kit/log #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bulk of this change set was automated by the following script which is being used to aid in converting the various exporters/projects to use slog: https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434 Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
tjhop
force-pushed
the
chore/adopt-slog
branch
from
de96ad4
to
90bb0c0
Compare
|
cc: @SuperQ |
Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
SuperQ
reviewed
Oct 18, 2024
Comment on lines
12
to
+14
| linters-settings: | ||
| errcheck: | ||
| exclude-functions: | ||
| # Never check for logger errors. | ||
| - (github.com/go-kit/log.Logger).Log | ||
| exclude-functions: [] |
There was a problem hiding this comment.
We can remove the whole section now.
SuperQ
approved these changes
Oct 18, 2024
bitfehler
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: