New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script for ZFS snapshots #136

Merged

dswarbrick merged 1 commit into prometheus-community:master from lstrojny:zfs-snapshots

May 26, 2023

Contributor

lstrojny commented Feb 6, 2023

Generates two metrics for ZFS snapshots:

zfs_snapshot_space_usage_bytes: snapshot space usage in bytes
zfs_snapshot_latest_snapshot_taken: UNIX timestamp

lstrojny mentioned this pull request

Export gauge of last ZFS snapshot timestamp prometheus/node_exporter#1776

Closed

Member

dswarbrick commented May 24, 2023

Please use the official Prometheus client_python library, rather than a homegrown metric printing function.

Contributor Author

lstrojny commented May 25, 2023

@dswarbrick done

dswarbrick reviewed

View reviewed changes

zfs-snapshots.py Show resolved Hide resolved

Member

dswarbrick commented May 26, 2023

@lstrojny Can you also include some sample command outputs (in the mock/fixtures directory) and optionally a mock zfs script (see existing examples in mock directory, so that we can (eventually) write tests for this collector?

dswarbrick reviewed

View reviewed changes

zfs-snapshots.py Outdated Show resolved Hide resolved

dswarbrick reviewed

View reviewed changes

mock/zfs Outdated Show resolved Hide resolved

dswarbrick reviewed

View reviewed changes

mock/fixtures/zfs list -p -H -t snapshot -o name,used,creation Outdated Show resolved Hide resolved

dswarbrick reviewed

View reviewed changes

zfs-snapshots.py Outdated Show resolved Hide resolved

dswarbrick reviewed

View reviewed changes

zfs-snapshots.py Outdated Show resolved Hide resolved

dswarbrick reviewed

View reviewed changes

zfs-snapshots.py Outdated Show resolved Hide resolved

dswarbrick reviewed

View reviewed changes

zfs-snapshots.py Outdated Show resolved Hide resolved


          Add script for ZFS snapshots

4180c67

Signed-off-by: Lars Strojny <lars@strojny.net>

dswarbrick approved these changes

View reviewed changes

dswarbrick merged commit fc283fe into prometheus-community:master

Member

dswarbrick commented May 26, 2023

Great stuff, thanks for your contribution.

PS: Any interest in merging the functionality of zfs_zpool.sh into this collector? 😉

Contributor Author

lstrojny commented May 27, 2023

Thanks! I probably won’t find the time to move zfs_zpool.sh into this collector, although a general purpose zfs.py would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet