Export last replay age in replication collector #1085
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitfehler
force-pushed
the
last_replay
branch
from
7a7a944 to
f6fb3a9
Compare
Sticksman
suggested changes
Nov 11, 2024
| rows := sqlmock.NewRows(columns). | ||
| AddRow(1000, 1) | ||
| AddRow(1000, 1, 3) |
There was a problem hiding this comment.
You should add an additional expected value below
The exported replication lag does not handle all failure modes, and can report 0 for replicas that are out of sync and incapable of recovery. A proper replacement for that metric would require a different approach (see e.g. prometheus-community#1007), but for a lot of folks, simply exporting the age of the last replay can provide a pretty strong signal for something being amiss. I think this solution might be preferable to prometheus-community#977, though the lag metric needs to be fixed or abandoned eventually. Signed-off-by: Conrad Hoffmann <ch@bitfehler.net>
bitfehler
force-pushed
the
last_replay
branch
from
f6fb3a9 to
2f77145
Compare
Sticksman
approved these changes
Nov 13, 2024
|
this can fix issue for postgres 17. since replication lag doesn`t report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exported replication lag does not handle all failure modes, and can report 0 for replicas that are out of sync and incapable of recovery.
A proper replacement for that metric would require a different approach (see e.g. #1007), but for a lot of folks, simply exporting the age of the last replay can provide a pretty strong signal for something being amiss.
I think this solution might be preferable to #977, though the lag metric needs to be fixed or abandoned eventually.