Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection issue to multiple databases. #655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

denisok
Copy link

@denisok denisok commented Jun 23, 2022

This is merge and conflict resolution for #529, please read more details there.

closes #529 #528

Co-Authored-By: Andrii Skomorokhov andrii.skomorokhov@percona.com
Signed-off-by: Denys Kondratenko denys.kondratenko@percona.com

Co-Authored-By: Andrii Skomorokhov <andrii.skomorokhov@percona.com>
Signed-off-by: Denys Kondratenko <denys.kondratenko@percona.com>
@SuperQ
Copy link
Contributor

SuperQ commented Jul 29, 2022

This needs a DCO sign-off. You can use git commit -s --amend to add it.

@SuperQ
Copy link
Contributor

SuperQ commented Jul 29, 2022

I wonder if this is still a problem now that we've merged #618. But I think it makes sense to not keep idle connections open anyway.

@SuperQ SuperQ requested a review from sysadmind July 29, 2022 12:29
@denisok
Copy link
Author

denisok commented Aug 10, 2022

This needs a DCO sign-off. You can use git commit -s --amend to add it.

it does has sign-off, but I also added original author, so DCO probably don't recognize it.

@ivyazmitinov
Copy link

We faced the need to disable idle connections too, but due to the connection not releasing memory for some reason.
Looking forward to this fix to be merged :)

@denisok
Copy link
Author

denisok commented Nov 16, 2022

@SuperQ any advise how I can keep DCO happy and still have original author?
image

@rishat-ishbulatov
Copy link

rishat-ishbulatov commented Dec 7, 2022

Faced a similar problem. Freezing the decision to merge is understandable, since there is no general good solution for this problem, and in case of re-creating the connection, it will increase processor usage.

@denisok
Copy link
Author

denisok commented Dec 7, 2022

@SuperQ due to idle connections the DB can't be dropped: https://jira.percona.com/browse/PMM-7958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants