-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup/add gitlab exporters #819
Cleanup/add gitlab exporters #819
Conversation
e024871
to
99056e4
Compare
I know this is still a draft and changes may still come. That said I took a brief look and I have 2 notes.
|
+1, we should be careful about what new collectors we enable by default. |
be28220
to
ba62ad1
Compare
Disabled everything by default and renamed marginalia (yeah I was kind of unclear on this term as well, I think summary was the best way I could read it as) |
a1d71b6
to
8f1a3e0
Compare
Will require #823 |
It's from the marginalia gem. |
@sysadmind @SuperQ this is ready to go |
11589b4
to
64bb2b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good so far. While we're importing these features, we should cleanup some best practices issues so we don't have to deal with them later.
Honestly, I would prefer to break this up into a few PRs. Doing this all as one big PR is hard to review. |
I’ll work on splitting it up today |
+1 I much prefer small PRs. Much easier to review. I would suggest one PR per "collector" |
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
bdf309a
to
57ea9d8
Compare
Closing for now |
This adds most of the diagonistic queries found in the gitlab queries.yaml: https://gitlab.com/gitlab-cookbooks/gitlab-exporters/-/blob/master/templates/postgres_exporter/queries.yaml.erb#L866
Several are difficult to write tests for: