Added support for metadata APIs. #49
Conversation
| Similar to query endpoint, for metadata endpoints `/api/v1/series`, `/api/v1/labels`, `/api/v1/label/<name>/values` the proxy inject the specified label in the `match` selector. | ||
|
|
||
| NOTE: At the moment of creation `/api/v1/labels`, `/api/v1/label/<name>/values` does not support `match[]` so they are disabled by default. Use `-enable-label-apis` flag to enable | ||
| those (see https://github.com/prometheus/prometheus/issues/6178 for tracking development). |
There was a problem hiding this comment.
i think this is a sane default (I was wondering why we don't enable it by default) 👍
There was a problem hiding this comment.
Because it gives false impression that tenancy is ensured, but literally implementation of label matcher does not exists yet (WIP PRs only)
|
LGTM 👍 Leaving final pass to another pair of eyes, cc @brancz @simonpasquier |
|
How about we wait for the APIs to implement these and then bump the Prometheus version compatibility? |
|
Should be fixed 🤗 |
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
|
LGTM 👍 Is there anything we need to do with respect to Frederic's comment in #49 (comment)? I see both upstream issues are still open. |
I think this will be a bit cruel for users because:
Being forward compatible is quite nice here I would say (: |
|
I'm ok with the flag, but I wouldn't merge and release this until the upstream API changes have been done, otherwise we may run into the situation that our assumptions now may not match the implementation in prometheus/prometheus. |
|
Can we move forward with this pr if it is ready? Thanos has supported label matchers in thanos-io/thanos@2508a70 so it would be good to have this feature, too |
|
I think Prometheus is stil behind. Let's move Prometheus one forward as well (: |
|
@bwplotka The prometheus pr is merged prometheus/prometheus#8301. Can we merge this? |
|
I think so. Any objections to merge this? @s-urbaniak @brancz @lilic ? |
|
lgtm |
Went ahead and implemented all APIs (: Disabled labels behind flag as there is only WIP PRs present right now.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com