Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical metrics for SCSI disks added, rebased #131

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

jthiltges
Copy link
Contributor

This is a rebase of PR #21 against master, with all credit going to @wwwlde.

  • Changes CounterValue to GaugeValue as requested
  • Adds --log=error in smartctl arguments to include SCSI error counters

Denys Lemeshko and others added 3 commits June 29, 2023 14:50
Signed-off-by: Denys Lemeshko <denys.lemeshko@pm.bet>
Signed-off-by: John Thiltges <jthiltges2@unl.edu>
Signed-off-by: John Thiltges <jthiltges2@unl.edu>
@wwwlde
Copy link

wwwlde commented Jun 30, 2023

Thanks @jthiltges! You are the best!

@k0ste
Copy link
Contributor

k0ste commented Jul 23, 2023

@SuperQ

@k0ste
Copy link
Contributor

k0ste commented Aug 7, 2023

@Nexucis maybe you can help with merges?

@Nexucis Nexucis requested a review from SuperQ August 9, 2023 11:27
@Nexucis
Copy link

Nexucis commented Aug 9, 2023

yeah that sounds ok.
I'm requesting a review from @SuperQ just in case he will have a last comment to do around that

@k0ste
Copy link
Contributor

k0ste commented Aug 9, 2023

yeah that sounds ok.
I'm requesting a review from @SuperQ just in case he will have a last comment to do around that

Thanks, we tag many times for SuperQ, we need someone less busy, for this project with merge rights
The community has made several PRs that make improvements - enough for the whole release!

@Nexucis
Copy link

Nexucis commented Aug 9, 2023

we should probably give the rights to someone from the community that is more active and aware about this code. That should be the good way.

If there is a candidat that will be great !

@NiceGuyIT
Copy link
Member

I'll look at this.

@NiceGuyIT NiceGuyIT merged commit 6448d79 into prometheus-community:master Aug 9, 2023
@k0ste k0ste mentioned this pull request Aug 10, 2023
@jthiltges jthiltges deleted the pr/21upd branch September 27, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants