Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.7.0 #50

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Release 0.7.0 #50

merged 1 commit into from
Aug 5, 2022

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Aug 4, 2022

First prometheus-community release.

Signed-off-by: SuperQ superq@gmail.com

@kfox1111
Copy link

kfox1111 commented Aug 4, 2022

I may be doing something wrong, but I'm getting:

>> checking license header
license header checking failed:
./gjsonext.go
./logging.go
./main.go
./metrics.go
./options.go
./readjson.go
./smartctl.go
./smartctlinfo.go

While working on trunk.

@kfox1111
Copy link

kfox1111 commented Aug 4, 2022

smartctl_exporter/Dockerfile seems to be missing things. (no smartctl at least)

@kfox1111
Copy link

kfox1111 commented Aug 4, 2022

I was able to get it to build and work with the following Dockerfile:

FROM golang:1.18
RUN \
  git clone https://github.com/prometheus-community/smartctl_exporter && \
  cd smartctl* && \
  sed -i 's/common-all: precheck style check_license lint yamllint unused build 
test/common-all: precheck style lint yamllint unused build test/g' Makefile.comm
on && \
  sed -i 's/-race//' Makefile.common && \
  export CGO_ENABLED=0 && \
  make

FROM alpine
COPY --from=0 /go/smartctl_exporter/smartctl_exporter /bin/smartctl_exporter
RUN \
  apk add --no-cache --update smartmontools
COPY smartctl_exporter.yaml /etc/smartctl_exporter.yaml
CMD ["/bin/smartctl_exporter"]

One change needed to get it to pass the license check above, and one because I build it statically and one of the flags in Makefile.common isn't supported in that environment.

In testing its working fairly well. but it still suffers from this issue too: #13

@SuperQ
Copy link
Contributor Author

SuperQ commented Aug 5, 2022

The Dockerfile is fine, we pre-build binaries in Prometheus projects, rather than maintain multi-stage Docker builds.

@SuperQ
Copy link
Contributor Author

SuperQ commented Aug 5, 2022

Added a fix for the license check issue.

First prometheus-community release.

* [FEATURE] Add various new metrics #14
* [BUGFIX] Fix exit code bit parsing #37

Signed-off-by: SuperQ <superq@gmail.com>
Copy link

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 920c342 into master Aug 5, 2022
@SuperQ SuperQ deleted the superq/release-0.7.0 branch August 5, 2022 01:37
@kfox1111
Copy link

kfox1111 commented Aug 5, 2022

The dockerfile looks to sill not include smartctl? Otherwise, everything else seems to be working well.

@SuperQ
Copy link
Contributor Author

SuperQ commented Aug 5, 2022

Oh, right, the actual smartctl tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants