-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.7.0 #50
Release 0.7.0 #50
Conversation
I may be doing something wrong, but I'm getting:
While working on trunk. |
smartctl_exporter/Dockerfile seems to be missing things. (no smartctl at least) |
I was able to get it to build and work with the following Dockerfile:
One change needed to get it to pass the license check above, and one because I build it statically and one of the flags in Makefile.common isn't supported in that environment. In testing its working fairly well. but it still suffers from this issue too: #13 |
The Dockerfile is fine, we pre-build binaries in Prometheus projects, rather than maintain multi-stage Docker builds. |
Added a fix for the license check issue. |
370c030
to
c058bbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The dockerfile looks to sill not include smartctl? Otherwise, everything else seems to be working well. |
Oh, right, the actual smartctl tool. |
First prometheus-community release.
Signed-off-by: SuperQ superq@gmail.com