-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jira integration template customfields #4029
base: main
Are you sure you want to change the base?
jira integration template customfields #4029
Conversation
a55ee26
to
3c16236
Compare
Damn, seems like I forgot that. I would recommend to extend the tests. |
40cf69c
to
1864d6c
Compare
1864d6c
to
5fab22c
Compare
Signed-off-by: Holger Waschke <waschkester@gmail.com>
…ra.host to default.tmpl Signed-off-by: Holger Waschke <waschkester@gmail.com>
Signed-off-by: Holger Waschke <waschkester@gmail.com>
5fab22c
to
a6f0147
Compare
No problem, I added a new template jira.host for the unit tests, please tell me if youre fine with this. otherwise we could use some existing template to test the customfields but I think with the new template it´s cleaner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but I'm not an official maintainer.
@simonpasquier is there any chance to get this in 0.28? |
I´ll fix the merge conflicts If the maintainer confirm this to be merged. |
6dbd7cd
to
15b7215
Compare
Signed-off-by: Holger Waschke <waschkester@gmail.com>
15b7215
to
a8c416f
Compare
@simonpasquier |
could someone have a look at the unit test TestClusterVSInstance, as im not able to reproduce this failure. |
We using templates to fill the jira customfields, e.g.
This code changes templates the custom fields before creating the issue, so we can use templates for custom fields