Include notifier type in retry logs and errors #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for publishing this. I tested it out on one of the servers having an issue with too many alerts coming in from prometheus and was able to get a more detailed output! |
stuartnelson3
approved these changes
Apr 11, 2017
brancz
reviewed
Apr 11, 2017
| @@ -543,9 +543,9 @@ func (r RetryStage) Exec(ctx context.Context, alerts ...*types.Alert) (context.C | |||
| case <-tick.C: | |||
| if retry, err := r.integration.Notify(ctx, alerts...); err != nil { | |||
| numFailedNotifications.WithLabelValues(r.integration.name).Inc() | |||
| log.Debugf("Notify attempt %d failed: %s", i, err) | |||
| log.Debugf("Notify attempt %d for %q failed: %s", i, r.integration.name, err) | |||
There was a problem hiding this comment.
Not sure this debug logging actually has any value as we ultimately always log errors happening in the notification pipeline, but I also don't mind keeping it as it's closer to the source here without many moving parts where it may get lost.
|
lgtm 👍 , your call whether we want to keep the debug logging or not |
|
👍 |
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Nov 6, 2017
This PR closes prometheus#690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.