Implement strict yaml unmarshalling. #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's fine, could you fix the tests? |
|
Yes, this is what I'm trying to do right now, even though I have found a really weird problem with the tests. I'll update everything as soon as it's ready, and probably I'll squash all the commits to satisfy the DCO check. |
Signed-off-by: manosf <manosf@protonmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup from prometheus/prometheus#4033 and prometheus/common/pull/127, I added strict yaml unmarshalling by updating the yaml vendor package and removing unnecessary checks and data structures.
I avoided code refactoring on the yaml Unmarshaler implementations inside
config/config.gofor this PR, in order to keep it simple. Please let me know if I should change it.