Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creating summaries without quantiles #118

Closed
juliusv opened this issue May 7, 2015 · 1 comment
Closed

Allow creating summaries without quantiles #118

juliusv opened this issue May 7, 2015 · 1 comment
Assignees
@beorn7
Labels
feature request
Milestone
v0.9

Comments

@juliusv
Copy link
Member

juliusv commented May 7, 2015

From reading the code, it seems like it's not possible to create summaries without any quantiles at the moment:

https://github.com/prometheus/client_golang/blob/master/prometheus/summary.go#L183-L185

If that len(...) == 0 check was changed to a ... == nil, then I guess it should work (one would then be able to pass in an empty, but constructed slice of objectives).

The same is true for histograms (although a summary/histogram without quantiles/buckets would behave identically to each other):

https://github.com/prometheus/client_golang/blob/master/prometheus/histogram.go#L184-L186
@beorn7
Copy link
Member

beorn7 commented May 7, 2015

Yeah, should be possible. For both cases, I guess.

@beorn7 beorn7 self-assigned this May 7, 2015
@beorn7 beorn7 added this to the v0.9 milestone Aug 19, 2016
beorn7 pushed a commit that referenced this issue Nov 23, 2016
Allow Summaries with empty objectives and deprecate DefObjectives
ffe6554 
This also updates all tests and examples to use explicitly set
objectives.

In v0.10, DefObjectives will be completely removed, and the default
Summary will have no objectives then.

Fixes #118
@beorn7 beorn7 mentioned this issue Nov 23, 2016
Merged
beorn7 pushed a commit that referenced this issue Nov 23, 2016
Allow Summaries with empty objectives and deprecate DefObjectives
9c4b778 
This also updates all tests and examples to use explicitly set
objectives.

In v0.10, DefObjectives will be completely removed, and the default
Summary will have no objectives then.

Fixes #118
@gregorychen3 gregorychen3 mentioned this issue Jul 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beorn7 beorn7

Labels
feature request
Projects
None yet
Milestone
v0.9
Development

No branches or pull requests
2 participants
@juliusv @beorn7