Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Add custom labels example #1626

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

ying-jeanne
Copy link
Contributor

@ying-jeanne ying-jeanne commented Sep 15, 2024

Fixes: #1585, tested in local. @bwplotka @ArthurSens @kakkoyun

Signed-off-by: Ying WANG <ying.wang@grafana.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One nit, otherwise LGTM 👍🏽

examples/customlabels/main.go Outdated Show resolved Hide resolved
ying-jeanne and others added 2 commits September 18, 2024 09:20
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Ying WANG <74549700+ying-jeanne@users.noreply.github.com>
@ying-jeanne
Copy link
Contributor Author

Thanks! One nit, otherwise LGTM 👍🏽

thanks for the review :), corrected so bad you don't like my service name.

Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ArthurSens ArthurSens merged commit 64158c5 into prometheus:main Sep 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to add go runtime metrics, with self-define label?
3 participants