Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut release v1.0.0 #608

Merged
merged 1 commit into from
Jun 15, 2019
Merged

Cut release v1.0.0 #608

merged 1 commit into from
Jun 15, 2019

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Jun 14, 2019

@krasi-georgiev please let me know if you see any blockers. We can also incorporate #603 if that makes sense.

Copy link
Contributor

@brian-brazil brian-brazil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

599 should be mentioned too, as a CHANGE

CHANGELOG.md Outdated
@@ -1,3 +1,14 @@
## 1.0.0 / 2019-06-15

_This release removes all previously deprecated features, resulting in the breaking changes listed below._
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a mention that you're now following semver (except for API).

@krasi-georgiev
Copy link
Contributor

We can also incorporate #603 if that makes sense.

yep I just merged it.

@beorn7
Copy link
Member Author

beorn7 commented Jun 14, 2019

Totally missed #599. Will add.

Signed-off-by: beorn7 <beorn@grafana.com>
@beorn7
Copy link
Member Author

beorn7 commented Jun 14, 2019

All comments addressed.

@brian-brazil
Copy link
Contributor

👍

@beorn7 beorn7 merged commit 4ab88e8 into master Jun 15, 2019
@beorn7 beorn7 deleted the beorn7/release branch June 15, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants