Fix build against GopherJS #897
Conversation
|
@paralin Do you want to continue working on this PR? |
|
Yes, I'm using it. @bwplotka I collect metrics from the browser using the stack at https://github.com/aperturerobotics - not all of it is open source yet :) |
paralin
force-pushed
the
gopherjs-compat
branch
from
dc49ac2 to
5945d56
Compare
|
@bwplotka rebased |
|
BTW, it's not running the CI: "First-time contributors need a maintainer to approve running workflows." |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
ping @paralin (: |
|
We might want to add CI too, otherwise it's easy to break your build in next change.... |
|
It would be nice if we can push this across the finish line @paralin. Not to get you stressed about it, but we have a planned release at the end of the week. However, if you can't make it. It's perfectly fine, we can have it in the next release. |
When building against GopherJS, ThreadCreateProfile and Getpid are not available. Return 1 to shim the functions. Signed-off-by: Christian Stewart <christian@paral.in>
paralin
force-pushed
the
gopherjs-compat
branch
from
5945d56 to
3dbdb6c
Compare
|
Rebased & build tested |
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Move build tags for licence header checks Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
When building against GopherJS, ThreadCreateProfile and Getpid are not available.
Return 1 to shim the functions.
Fixes "gopherjs build ./..."