Add abstract build method to MetricSnapshot.Builder #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mickael Maison <mickael.maison@gmail.com>
|
@fstab @dhoard @tomwilkie Can you take a look? Thanks |
|
Ping @fstab @dhoard @tomwilkie |
dhoard
approved these changes
Sep 7, 2024
|
@mimaison Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having an abstract
build()method allows writing generic code for the different builders.For context, I'm currently updating a library from
simpleclientto the new 1.X version. The library converts metrics from Apache Kafka where we can have multiple metric objects with the same metric name but different labels.With
simpleclient, we could also have multipleMetricFamilySampleswith the same name, but that's not the case anymore withMetricSnapshotswhere eachMetricSnapshotmust have a unique name.So when converting metrics from Kafka, we need to keep un-built
MetricSnapshot.Builderand add datapoints when we find metrics with the same names. In this example being able to store variousMetricSnapshot.Builderobjects in a collection is useful and allows building them all easily.