fix buffer sync logic using modern concurrency primitives #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
force-pushed
the
buffer-sync
branch
2 times, most recently
from
4840174 to
4ab179b
Compare
zeitlinger
force-pushed
the
buffer-sync
branch
from
4ab179b to
b5a40e6
Compare
zeitlinger
commented
Oct 9, 2024
| * HistogramBenchmark.prometheusClassic thrpt 25 1528.871 ± 43.598 ops/s | ||
| * HistogramBenchmark.prometheusNative thrpt 25 1282.643 ± 110.210 ops/s | ||
| * HistogramBenchmark.simpleclient thrpt 25 3376.016 ± 173.545 ops/s | ||
| * HistogramBenchmark.openTelemetryClassic thrpt 25 333.576 ± 17.158 ops/s |
There was a problem hiding this comment.
@fstab some are better some are worse (same computer) - is this also your experience?
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
zeitlinger
force-pushed
the
buffer-sync
branch
from
b5a40e6 to
c3074b8
Compare
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative suggestion for #970