Remove all languages but Go and add a deprecation note #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-brazil
reviewed
Dec 2, 2019
README.md
Outdated
| library](https://github.com/prometheus/client_golang), however, has been built | ||
| around the protobuf-based data model. As a byproduct thereof, it is still able | ||
| to expose the protobuf-based exposition format. The Go instrumentation library | ||
| is the only remaining Prometheus project directly using this repository. |
There was a problem hiding this comment.
official
There's a few things outside this org using it I gather.
There was a problem hiding this comment.
I thought "Prometheus project" reads as "project in the Prometheus GitHub org". I'm not a great fan of the word "official". I'll reword as "…is the only remaining project within the Prometheus GitHub org…".
Signed-off-by: beorn7 <beorn@grafana.com>
beorn7
force-pushed
the
beorn7/deprecation
branch
from
8a61461 to
a661ac3
Compare
1 task
thaJeztah
added a commit
to thaJeztah/containerd
that referenced
this pull request
Jan 13, 2020
full diff: prometheus/client_model@99fa1f4...v0.1.0 - prometheus/client_model#22 add `go_package`, regenerate Go binding file - prometheus/client_model#31 Support Go Modules - prometheus/client_model#38 Remove all languages but Go and add a deprecation note Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 16, 2020
full diff: prometheus/client_model@6f38060...v0.1.0 - prometheus/client_model#22 add `go_package`, regenerate Go binding file - prometheus/client_model#31 Support Go Modules - prometheus/client_model#38 Remove all languages but Go and add a deprecation note Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jan 17, 2020
full diff: prometheus/client_model@6f38060...v0.1.0 - prometheus/client_model#22 add `go_package`, regenerate Go binding file - prometheus/client_model#31 Support Go Modules - prometheus/client_model#38 Remove all languages but Go and add a deprecation note Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 9c99f8b9b3d16e1975f07ae08f418949f76e4a02 Component: engine
tussennet
pushed a commit
to tussennet/containerd
that referenced
this pull request
Sep 11, 2020
full diff: prometheus/client_model@99fa1f4...v0.1.0 - prometheus/client_model#22 add `go_package`, regenerate Go binding file - prometheus/client_model#31 Support Go Modules - prometheus/client_model#38 Remove all languages but Go and add a deprecation note Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37 (and implicitly #36).