Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The _created auto-created metrics (e.g. for Counter) cause failure of promtool check metrics because of lack of HELP #470

Closed
davidlukac opened this issue Oct 1, 2019 · 1 comment

Comments

@davidlukac
Copy link
Contributor

  • prometheus/client_python version: 0.7.1
  • Python version 3.7.1
  • promtool version from current HEAD: 2.13.0-rc.0

When creating a counter, e.g.

c = Counter('some_counter', "Some counter")

this will create two metrics:

# HELP some_counter Some counter
# TYPE some_counter counter
some_counter_total 4.0
# TYPE some_counter_created gauge
some_counter_created 1.5699349744874952e+09

The output lacks the HELP line for the _created metric. This causes a failure with promtool:

$ curl -s http://localhost:8080/metrics | promtool check metrics
some_counter_created no help text
davidlukac added a commit to davidlukac/client_python that referenced this issue Oct 1, 2019
Signed-off-by: David Lukac <1215290+davidlukac@users.noreply.github.com>
brian-brazil pushed a commit that referenced this issue Oct 1, 2019
Signed-off-by: David Lukac <1215290+davidlukac@users.noreply.github.com>
@davidlukac
Copy link
Contributor Author

Resolved in PR #471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant