Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact types.MethodType between 2 and 3 #403

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Compact types.MethodType between 2 and 3 #403

merged 1 commit into from
Jun 19, 2019

Conversation

Hanaasagi
Copy link
Contributor

In Python2, the MethodType constructor requires the obj‘s class to be passed. Compact code is copied from six https://github.com/benjaminp/six/blob/8da94b8a153ceb0d6417d76729ba75e80eaa75c1/six.py#L545-L556

@brian-brazil
Copy link
Contributor

Can you add the DCO?

@Hanaasagi
compact MethodType between 2 and 3
3b48129 
Signed-off-by: Hanaasagi <ambiguous404@gmail.com>
@Hanaasagi Hanaasagi force-pushed the small-fix-for-bound-method branch from 8eb2834 to 3b48129 Compare May 8, 2019 12:08
@Hanaasagi
Copy link
Contributor Author

Is this ok?

@brian-brazil brian-brazil merged commit ae86f1c into prometheus:master Jun 19, 2019
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hanaasagi @brian-brazil