Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiprocess: don't crash on missing gauge_live/sum files #424

Merged
merged 1 commit into from
Jun 18, 2019
Merged

multiprocess: don't crash on missing gauge_live/sum files #424

merged 1 commit into from
Jun 18, 2019

Conversation

xavfernandez
Copy link
Contributor

@xavfernandez xavfernandez commented Jun 13, 2019 •
edited
Loading

Closes #425

@xavfernandez xavfernandez mentioned this pull request Jun 13, 2019
Closed
@xavfernandez xavfernandez force-pushed the xfernandez/ignore_missing_gauge_livexxx branch 4 times, most recently from 63b8390 to 4327668 Compare June 13, 2019 11:45
@brian-brazil
Copy link
Contributor

Thanks, there's a test failure.

@xavfernandez
Copy link
Contributor Author

xavfernandez commented Jun 13, 2019 •
edited
Loading

Thanks, there's a test failure.

Yes, it is apparently failing in master too: https://travis-ci.org/prometheus/client_python/builds/542696662
I've just opened #427 for it.

@xavfernandez xavfernandez mentioned this pull request Jun 17, 2019
Closed
@xavfernandez
multiprocess: don't crash on missing gauge_live/sum files
0514a83 
Fixes prometheus#425

Signed-off-by: Xavier Fernandez <xavier.fernandez@polyconseil.fr>
@xavfernandez xavfernandez force-pushed the xfernandez/ignore_missing_gauge_livexxx branch from 4327668 to 0514a83 Compare June 18, 2019 11:38
@xavfernandez
Copy link
Contributor Author

With #428 merged, all tests now pass.

@brian-brazil brian-brazil merged commit 04c112a into prometheus:master Jun 18, 2019
@brian-brazil
Copy link
Contributor

Thanks!

@xavfernandez xavfernandez deleted the xfernandez/ignore_missing_gauge_livexxx branch June 18, 2019 11:49
@xavfernandez
Copy link
Contributor Author

Thanks!

No problem, thanks for your work :)
Any chance for a patch release ? Or any idea when the next minor will be released ?

@brian-brazil
Copy link
Contributor

I'll have a better idea this evening after the OpenMetrics meeting.

@xavfernandez
Copy link
Contributor Author

I'll have a better idea this evening after the OpenMetrics meeting.

How did it go ? 😀

@brian-brazil
Copy link
Contributor

We didn't discuss the relevant point, so I've put a release on my todo list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultiProcessCollector.collect() crashing on missing files
2 participants
@xavfernandez @brian-brazil