Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Quart example #513

Closed
wants to merge 2 commits into from
Closed

Added Quart example #513

wants to merge 2 commits into from

Conversation

Skeen
Copy link
Contributor

@Skeen Skeen commented Feb 14, 2020

This PR builds ontop #512.

This PR introduces a Quart counterpart to the current Flask example.

This example is split off from the other PR as it currently does not work.
See: https://gitlab.com/pgjones/quart/issues/300
And the corresponding (but yet unreleased fix): https://gitlab.com/pgjones/hypercorn/commit/7da4c8e2542d702f9df11a5c8960d1181e079fb5

Signed-off-by: Emil Madsen <sovende@gmail.com>
Signed-off-by: Emil Madsen <sovende@gmail.com>
```

Visit http://localhost:8000/ to see the metrics

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the distinguishing change for this PR.

@Skeen Skeen requested a review from brian-brazil February 14, 2020 21:50
@brian-brazil
Copy link
Contributor

I'm not accepting support/docs for additional frameworks, however you're free to document this yourself on a blog/library as appropriate.

@Skeen Skeen closed this Feb 14, 2020
@Skeen
Copy link
Contributor Author

Skeen commented Feb 14, 2020

This PR was mainly added to fulfill the duality of flask versus quart with regards to WSGI versus ASGI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants