Add tags support to GraphiteBridge #618
Conversation
Graphite has support for tagged metrics with a syntax very similar to the non-tagged format. Update GraphiteBridge to support it. Signed-off-by: Matt Wilder <me@partcyb.org>
partcyborg
force-pushed
the
graphite_bridge_tags
branch
from
b0ca484 to
1041d23
Compare
|
@csmarchbanks (new project maintainer) |
README.md
Outdated
| ```python | ||
| from prometheus_client.bridge.graphite import GraphiteBridge | ||
|
|
||
| gb = GraphiteBridge('graphite.your.org', 2003, tags=True) |
There was a problem hiding this comment.
This should be GraphiteBridge(('graphite.your.org', 2003), tags=True) for the same reason as the last comment.
* Fix `GraphiteBridge` calls in README.md * Place the new `tags` kwarg at the end of the `GraphiteBridge` constructor. Signed-off-by: Matt Wilder <me@partcyb.org>
README.md
Outdated
| ```python | ||
| from prometheus_client.bridge.graphite import GraphiteBridge | ||
|
|
||
| gb = GraphiteBridge(('graphite.your.org', 2003, tags=True)) |
There was a problem hiding this comment.
Too many things in the tuple here :)
It should be GraphiteBridge(('graphite.your.org', 2003), tags=True)
Signed-off-by: Matt Wilder <me@partcyb.org>
partcyborg
force-pushed
the
graphite_bridge_tags
branch
from
832f702 to
7f83b9e
Compare
|
Thanks for the quick review! Do you have a general idea of when a prometheus_client release with this change might make its way to pypi? It would just be nice to know when I stop building this from the git repo in our relevant Dockerfiles. |
|
Good question, my estimate is within a month or so. As you saw, I recently took over as maintainer of this repo and am still on-boarding some. |
|
Sounds good. Thanks again and good luck with maintainership. |
Add tags support to GraphiteBridge Graphite has support for tagged metrics with a syntax very similar to the non-tagged format. Update GraphiteBridge to support it. Signed-off-by: Matt Wilder <me@partcyb.org> Signed-off-by: Trinh <iy3827-admin@dupont.com>
Graphite has support for tagged metrics with a syntax very similar to
the non-tagged format. Update GraphiteBridge to support it.
Graphite's carbon tags format is explained here: https://grafana.com/blog/2018/01/11/graphite-1.1-teaching-an-old-dog-new-tricks
@brian-brazil