Support exemplars for single process mode #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csmarchbanks
force-pushed
the
exemplars
branch
2 times, most recently
from
c47b2c8 to
e6e5c2d
Compare
Closed
csmarchbanks
force-pushed
the
exemplars
branch
6 times, most recently
from
26dcc3b to
1bd82fb
Compare
Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
|
Hi @csmarchbanks @brian-brazil 👋🏽 Thx |
|
Hi @yacir, I am testing this out with some teammates soon internally. Unless some concerns come up I plan to merge and release this soon afterward. |
gerboland
approved these changes
Sep 15, 2021
|
@csmarchbanks @gerboland |
|
OpenMetrics does not allow gauges to have exemplars so they are not supported. It looks like custom collectors only have partial support right now, exemplars can only be specified for histograms. It would be good to add support for Counters and GaugeHistograms for custom collectors as well. Would you be willing to open an issue (or PR if you want) for support in custom collectors? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for exemplars for counters and histograms when instrumenting your code.