Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 2.7 and 3.4-3.5 #718

Merged
merged 4 commits into from
Nov 17, 2021

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 2, 2021

Fixes #717.

Follow on from #706 (comment).

Python 2.7 and 3.4 - 3.5 are EOL:

cycle latest release eol
3.6 3.6.15 2016-12-23 2021-12-23
3.5 3.5.10 2015-09-30 2020-09-13
3.4 3.4.10 2014-03-16 2019-03-18
2.7 2.7.18 2010-07-03 2020-01-01

https://endoflife.date/python

Here's the pip installs for prometheus_client from PyPI for October 2021 showing under 2% usage:

category percent downloads
3.7 72.89% 22,490,512
3.8 14.20% 4,380,172
3.6 6.85% 2,113,567
3.9 2.93% 904,146
null 1.30% 402,541
2.7 1.30% 401,660
3.5 0.27% 82,532
3.10 0.26% 79,007
3.4 0.00% 736
3.11 0.00% 184
3.3 0.00% 2
Total 30,855,059

Source: pip install -U pypistats && pypistats python_minor prometheus_client --last-month

In fact, 2.7 + 3.4 + 3.5 usage combined is under 2% = 1.57%.

Also upgraded Python syntax with https://github.com/asottile/pyupgrade --py36-plus, and removed universal wheels, only needed for suporting both Python 2 and 3.

@csmarchbanks
Copy link
Member

Thanks! This will close #717 (just making a reference for the future).

I posted that to the -dev mailing list yesterday, and am waiting to hear if there are significant concerns from the community before moving forward with review/merge on this. If I don't hear anything within a week at the most we can certainly move forward.

@csmarchbanks
Copy link
Member

I haven't heard any concerns on the other issue, so I plan to review this sometime this week!

Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, thanks for all your work! I left a couple comments/questions, but they are pretty minor. I might try to get a second set of eyes to make sure I am not missing any python 2/3 conversion differences.

README.md Outdated Show resolved Hide resolved
prometheus_client/decorator.py Outdated Show resolved Hide resolved
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me, double checking with a second reviewer, then will merge. Thanks again!

@csmarchbanks csmarchbanks merged commit 038b5bd into prometheus:master Nov 17, 2021
@hugovk hugovk deleted the rm-eol branch November 17, 2021 15:29
@akx akx mentioned this pull request Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End Support for Python 2.7
2 participants