Skip to content

Commit

Permalink
Merge pull request #183 from prometheus/document_startup_file_cleanup
Browse files Browse the repository at this point in the history
Document how to clean up work dir for DirectFileStore on startup
  • Loading branch information
Daniel Magliola authored Feb 24, 2020
2 parents 4f8de6c + 209db7c commit 2f91bbd
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,19 @@ you store your metric files (specified when initializing the `DirectFileStore`)
when your app starts. Otherwise, each app run will continue exporting the metrics from the
previous run.

If you have this issue, one way to do this is to run code similar to this as part of you
initialization:

```ruby
Dir["#{app_path}/tmp/prometheus/*.bin"].each do |file_path|
File.unlink(file_path)
end
```

If you are running in pre-fork servers (such as Unicorn or Puma with multiple processes),
make sure you do this **before** the server forks. Otherwise, each child process may delete
files created by other processes on *this* run, instead of deleting old files.

**Large numbers of files**: Because there is an individual file per metric and per process
(which is done to optimize for observation performance), you may end up with a large number
of files. We don't currently have a solution for this problem, but we're working on it.
Expand Down

0 comments on commit 2f91bbd

Please sign in to comment.