-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements #init_label_set method for all metric classes #156
Conversation
a67a90a
to
6ad23c9
Compare
@SuperQ @dmagliola @Sinjo can I get a review on this on when you have the chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Joao! Sorry for the slow review!
I really like this, thank you for doing it!
I'd like to simplify the code in Histograms a bit (see my comments there), but the rest looks great.
One more important thing, though: Could you add a section to the Readme, probably right before "Reserved labels", briefly explaning the problem and how this method solves it? (you don't want metrics to spontaneously appear the first time they're incremented, you want them to be there from the beginning, so if you know what your labels values are upfront, you can declare them)
And a brief example ideally :)
Thank you
85c6081
to
c819556
Compare
@dmagliola Feedback addressed let me know what you think! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few requests, mostly around the README, and then we're ready to merge!
c819556
to
ba2a565
Compare
So many typos 😬 @dmagliola Ready for a second round 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 tiny changes. Please do those two and i'll merge it tomorrow!
Thanks!
Signed-off-by: Joao Bernardo <jb.amaro95@gmail.com>
ba2a565
to
0e0f17f
Compare
Done 🚀 |
Thank you @jbernardo95 for this! |
This a draft PR of a solution for the problem described in #141.