Include SCRIPT_NAME when determining path in Collector #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When determining the path for a request, `Rack::Request` prefixes the `SCRIPT_NAME`, [as seen here][1]. This is a problem with our current code when using mountable engines, where the engine part of the path gets lost. This patch fixes that to include `SCRIPT_NAME` as part of the path. NOTE: This is not backwards compatible. Labels will change in existing metrics. We will cut a new major version once we ship this. [1]: https://github.com/rack/rack/blob/294fd239a71aab805877790f0a92ee3c72e67d79/lib/rack/request.rb#L512 Co-authored-by: Ian Ker-Seymer <i.kerseymer@gmail.com> Co-authored-by: Ruslan Kornev <oganer@gmail.com> Signed-off-by: Daniel Magliola <dmagliola@crystalgears.com>
dmagliola
force-pushed
the
add_script_name_in_collector_path
branch
from
d14e4dd to
0761f59
Compare
This was referenced Oct 14, 2020
Sinjo
approved these changes
Oct 14, 2020
|
Awesome stuff. Excited for the new major! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When determining the path for a request,
Rack::Requestprefixes theSCRIPT_NAME, as seen here.This is a problem with our current code when using mountable engines,
where the engine part of the path gets lost.
This patch fixes that to include
SCRIPT_NAMEas part of the path.NOTE: This is not backwards compatible. Labels will change in existing
metrics. We will cut a new major version once we ship this.