Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to explicit method call for Basic Auth credentials in push client #242

Merged
merged 1 commit into from
Jan 9, 2022

Commits on Jan 9, 2022

  1. Move to explicit method call for Basic Auth credentials in push client

    While URLs do support passing Basic Auth credentials using the
    `http://user:password@example.com/` syntax, the username and password in
    that syntax have to follow the usual rules for URL encoding of
    characters per RFC 3986
    (https://datatracker.ietf.org/doc/html/rfc3986#section-2.1).
    
    Rather than place the burden of correctly performing that encoding on
    users of this gem, we decided to have a separate method for supplying
    Basic Auth credentials, with no requirement to URL encode the characters
    in them.
    
    Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
    Sinjo committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    3a70f73 View commit details
    Browse the repository at this point in the history