Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md and gem version for 3.0.0 release #244

Merged
merged 4 commits into from
Feb 5, 2022

Conversation

Sinjo
Copy link
Member

@Sinjo Sinjo commented Jan 28, 2022

@dmagliola I've pulled in your work from #228, which we were going to use to cut an interim 2.2.0 release, and combined it all into one big section for the 3.0.0 release which we decided to go with instead.

Fixes #241

@Sinjo Sinjo requested a review from dmagliola January 28, 2022 02:03
@Sinjo Sinjo force-pushed the sinjo-release-3.0.0 branch 2 times, most recently from a3fea5f to ddb3035 Compare January 28, 2022 02:10
@Sinjo Sinjo added this to the v3.0.0 milestone Jan 28, 2022
Copy link
Collaborator

@dmagliola dmagliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)
Looking forward to releasing this one!

CHANGELOG.md Show resolved Hide resolved
Includes the changes in `master` that we'll release in `2.2.0`, and
the ones that we can't because of breaking changes, which we'll release
in `3.0.0`

Signed-off-by: Daniel Magliola <dmagliola@crystalgears.com>
Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
@Sinjo
Copy link
Member Author

Sinjo commented Feb 1, 2022

@dmagliola One question before we merge this: do you think it's worth us putting a release candidate out given the number of changes?

I'm thinking it might be worth it if we also post it on prometheus-announce so that there's more chance of people giving it a go. Equally, I know how reticent people are to use software that's labelled as a release candidate (but would be totally fine with using if it were a proper release), which limits their value.

@dmagliola
Copy link
Collaborator

I've taken a look at the changes which we introduced, and I feel like we can be fairly confident that they'll work.

I'd put out a release candidate if we ever merge lzap's change to the DirectFileStore, that kind of change seems more like something that could have hard-to-predict implications.

What we've done in these commits is the kind of thing that is pretty testable, and it's tested. I think we can release as 3.0.0, to be honest.

@Sinjo Sinjo merged commit 9431ca2 into master Feb 5, 2022
@Sinjo Sinjo deleted the sinjo-release-3.0.0 branch February 5, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CHANGELOG.md for 3.0.0 release
2 participants