Breaking change in 0.48.0

[nicolaasuni-vonage]

The latest version 0.48.0 breaks an existing workflow.
#576

After upgrading to github.com/prometheus/common v0.48.0 and running golangci-lint on the source code I get the following error:

[...]/gosrvlib/target/binutil/golangci-lint run --exclude-use-default=false --max-issues-per-linter 0 --max-same-issues 0 ./pkg/...
WARN [runner] Can't run linter goanalysis_metalinter: buildssa: failed to load package testutil: could not load export data: no export data for "github.com/prometheus/client_golang/prometheus/testutil" 
ERRO Running error: can't run linter goanalysis_metalinter
buildssa: failed to load package testutil: could not load export data: no export data for "github.com/prometheus/client_golang/prometheus/testutil" 

To reproduce:

git clone https://github.com/Vonage/gosrvlib.git
cd gosrvlib
make modupdate x

[beorn7]

@ywwg could you check if there is an easy fix?

I can look into this next week, but perhaps you can beat me to it.

[ywwg]

looking in to this

[ywwg]

client_golang needs an update to work with this new version of common

[ywwg]

prometheus/client_golang#1447

[ywwg]

Client/Common should be fixed, if you update both and still have problems please reopen

[nicolaasuni-vonage]

It looks like the client_golang has not been tagged, so the problem persist.

[nicolaasuni-vonage]

@ywwg or @beorn7 Could you please reopen this issue and keep it open until the problem is fixed? It will be easy to track and avoid opening new issues for the same problem.

[beorn7]

v1.19.0 of client_golang is on its way: prometheus/client_golang#1451

Note that the prometheus/common Go module is pre v1.0, so breaking changes are happening by design.
This one is even called out in the release notes: https://github.com/prometheus/common/releases/tag/v0.48.0
I don't see value in keeping this issue open.

The fixes needed are on the side of the code using this Go module, so you could file issues over there (but in the case of prometheus/client_golang, the fix is already merged, it's just about the release, and even that is probably happening later today).

[ArthurSens]

There you go!

https://github.com/prometheus/client_golang/releases/tag/v1.19.0

[nicolaasuni-vonage]

Thank you.