Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump prometheus/common version #1447

Closed
wants to merge 2 commits into from
Closed

deps: bump prometheus/common version #1447

wants to merge 2 commits into from

Conversation

tdakkota
Copy link

Fixes #1446

@tdakkota
chore: bump prometheus/common version
fb04c7f 
Signed-off-by: tdakkota <tanc13@yandex.ru>
@tdakkota
fix: do not use private constants
f10b2a3 
Signed-off-by: tdakkota <tanc13@yandex.ru>
@ywwg
Copy link
Member

ywwg commented Feb 23, 2024

this requires some test changes, too, sorry

@ywwg
Copy link
Member

ywwg commented Feb 23, 2024 •
edited
Loading

I had been working on this but it should be easy to move here

#1448

This was referenced Feb 23, 2024
Merged
Closed
@ArthurSens ArthurSens mentioned this pull request Feb 23, 2024
Merged
@ywwg
Copy link
Member

ywwg commented Feb 23, 2024

thank you for this, we're going to fix up the other failures in my previous WIP fix here: #1448

@ArthurSens
Copy link
Member

thanks for the PR, we got everything working on #1448!

@ArthurSens ArthurSens closed this Feb 23, 2024
@tdakkota tdakkota deleted the chore/fix-promlint branch February 24, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build break after updating
3 participants
@tdakkota @ywwg @ArthurSens