Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node_disk_info metric #2207

Closed
discordianfish opened this issue Nov 12, 2021 · 4 comments · May be fixed by #2216
Closed

Add node_disk_info metric #2207

discordianfish opened this issue Nov 12, 2021 · 4 comments · May be fixed by #2216
Labels
enhancement

Comments

@discordianfish
Copy link
Member

As discussed in #304, we should add a node_disk_info metric that includes uuid and possibly other disk identifiers.
Parsing should go in procfs.
@discordianfish discordianfish mentioned this issue Nov 12, 2021
Closed
@discordianfish
Copy link
Member Author

Related: #2207

@ventifus
Copy link
Contributor

I've been looking into adding this. One step in that direction is prometheus/procfs/pull/412. I'll get it rebased so it's ready to merge.

@ventifus ventifus mentioned this issue Nov 19, 2021
Draft
@BenoitKnecht BenoitKnecht mentioned this issue Jun 14, 2022
Merged
@jcpunk
Copy link

jcpunk commented Nov 16, 2022

I'd love to see this feature as well.

@discordianfish
Copy link
Member Author

This actually has been implemented for a while, so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update node_disk_info with additional labels ventifus/node_exporter
3 participants
@discordianfish @jcpunk @ventifus