Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic with DBus #242

Closed
turb opened this issue May 16, 2016 · 8 comments · Fixed by #423
Closed

Panic with DBus #242

turb opened this issue May 16, 2016 · 8 comments · Fixed by #423
Labels

Comments

@turb
Copy link

turb commented May 16, 2016

Since we activated systemd collector, it's the second time (four days after the first one) the exporter fails with panic, twice on the same host:

panic: send on closed channel

goroutine 672945 [running]:
panic(0x8bf8e0, 0xc820201ed0)
        /usr/lib/go/src/runtime/panic.go:464 +0x3e6
github.com/godbus/dbus.(*Conn).inWorker(0xc820158360)
        /build/prometheus-node-exporter-0.12.0+ds+really0.12.0/obj-x86_64-linux-gnu/src/github.com/godbus/dbus/conn.go:342 +0x11c3
created by github.com/godbus/dbus.(*Conn).Auth
        /build/prometheus-node-exporter-0.12.0+ds+really0.12.0/obj-x86_64-linux-gnu/src/github.com/godbus/dbus/auth.go:118 +0xf3d

We use the Debian-packaged exporter.

Starting again the exporter solves it.

@grobie grobie added the bug label May 16, 2016
@turb
Copy link
Author

turb commented Jun 1, 2016

Still happens from time to time.

I expect it to be solved on OS restart (it's only with one specific instance); however we can't afford to reboot it just for this.

@vrischmann
Copy link

We're running into this bug constantly (happens at least every couple days) on our nodes. We're on Debian 8. Any news on this bug ?

@juliusv
Copy link
Member

juliusv commented Sep 23, 2016

No news yet - any debugging help welcome.

@vrischmann
Copy link

godbus/dbus#45 looks lilke it's the same bug ? It appears to be fixed in a later version of godbus than what is vendored with node_exporter.

I think I'll try to build a version of node_exporter with godbus updated and report back if it fixes the problem.

@vrischmann
Copy link

Hello,

so I forgot to report back. I did build a version with the latest godbus and it worked great since then, no panics to report.

I'm reporting back now because we're upgrading to 0.13.0 and I saw godbus isn't updated. It's not a big deal but any chance the next version will use an updated godbus ?

Thanks.

@SuperQ
Copy link
Member

SuperQ commented Dec 16, 2016

PR to update vendoring (might as well catch them all). #372

@SuperQ
Copy link
Member

SuperQ commented Dec 19, 2016

#372 merged, I'll be starting a new release in January after a few more PRs get cleaned up and merged.

@discordianfish
Copy link
Member

Given that #372 is merged, I'd consider this fixed and close the issue.
@vrischmann If you see this again with current master, feel free to reopen the issue.

tamcore pushed a commit to gitgrave/node_exporter that referenced this issue Oct 22, 2024
procfs: tidy up NetUnix APIs and internals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants